Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: missing deprecated callout for list-group-item-variant() mixin #37829

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 6, 2023

Description

This PR suggests to add a deprecate callout in the List group > Sass mixins section for consistency with what's done in Alerts > Sass mixins section.

Indeed alert-variant() deprecated mixin got this callout and it's missing for list-group-item-variant() deprecated mixin.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond marked this pull request as ready for review January 6, 2023 20:15
@julien-deramond julien-deramond requested a review from a team as a code owner January 6, 2023 20:15
@mdo mdo merged commit 980116e into main Jan 7, 2023
@mdo mdo deleted the main-jd-missing-deprecated-in-callout-list-groups branch January 7, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants